Layout Grid Availability - featureConfig implementation#14667
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
2 tasks
antonis
reviewed
May 20, 2021
WordPress/src/main/java/org/wordpress/android/util/SiteUtils.java
Outdated
Show resolved
Hide resolved
|
You can test the changes on this Pull Request by downloading the APK here. |
antonis
approved these changes
May 21, 2021
Contributor
There was a problem hiding this comment.
Great work @enejb 👍
The code changes LGTM and the app works as expected 🎉
I tested this both with metro and the CI produced APK:
- I took the liberty of pushing a version change pointing at the latest commit that has an artifact on S3 to produce the APK.
- The remaining failing lint check is due to a missing line at the end of
LayoutGridBlockFeatureConfig.kt
mzorz
reviewed
May 24, 2021
mzorz
reviewed
May 24, 2021
enejb
force-pushed
the
layout-grid-block-availability
branch
from
f910d7f to
3fc8d2b
Compare
… version with the bridge changes
Generated by 🚫 dangerJS |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #13804
It adds the availability information that is needed for the layout grid block to be available to only .com sites for now and in the future to all sites that have the layout grid block.
Related PR:
WordPress/gutenberg#31777
Related wordpress-mobile/gutenberg-mobile#3513
To test:
CASE A:
- An business site as well as a simple site should see the layout grid block.
CASE B:
- An Jetpack site or a .org site should NOT see the layout grid block.